]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
authPrompt: Wiggle error messages coming from the Fingerprint service
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Mon, 1 Feb 2021 18:44:00 +0000 (19:44 +0100)
committerRay Strode <halfline@gmail.com>
Mon, 15 Feb 2021 16:58:50 +0000 (16:58 +0000)
When error messages are coming from the fingerprint service they are actual
failures due to an user input in some device, in so in such case we
can highlight this by using a wiggle effect.

This mimics what has been done in gnome-control-center fingerprint panel
and part of [1].

[1] https://gitlab.gnome.org/Teams/Design/os-mockups/-/issues/56

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1652>

js/gdm/authPrompt.js

index 95f07a6a3f177ee8f6490846b1f95157bd319005..7b5d03ef4254a7b25cb35113507836264c7c5da2 100644 (file)
@@ -430,6 +430,10 @@ var AuthPrompt = GObject.registerClass({
         } else {
             this._message.opacity = 0;
         }
+
+        if (type === GdmUtil.MessageType.ERROR &&
+            this._userVerifier.serviceIsFingerprint(serviceName))
+            Util.wiggle(this._message);
     }
 
     updateSensitivity(sensitive) {